Skip to content

feat: allow ts_project to point to the eslint config #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2025
Merged

feat: allow ts_project to point to the eslint config #848

merged 2 commits into from
Nov 5, 2025

Conversation

@alexeagle
Copy link
Member

@alexeagle alexeagle commented Aug 19, 2025

ESLint flat config is not ergonomic in a monorepo. Many projects would prefer to have the eslint config locally, for example one-per-package.json

See aspect-build/rules_lint@main...eslint_no_flat for how this may be used.

FYI @jfirebaugh @walkerburgin

@alexeagle
feat: allow ts_project to point to the eslint config
29a1e08 
ESLint flat config is not ergonomic in a monorepo.
Many projects would prefer to have the eslint config locally, for example one-per-package.json

See aspect-build/rules_lint@main...eslint_no_flat for how this may be used.
@alexeagle alexeagle requested a review from jbedard August 19, 2025 15:19
alexeagle
alexeagle commented Aug 19, 2025
View reviewed changes
@aspect-workflows
Copy link

aspect-workflows bot commented Aug 19, 2025 •
edited
Loading

Test (Bazel 6.x) (Test)

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.

Test (Bazel 7.x) (Test)

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.

Test (Bazel 8.x) (Test)

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.

Bazel-7

e2e/bzlmodules

All tests were cache hits

1 test (100.0%) was fully cached saving 25ms.

Bazel-8

e2e/bzlmodules

All tests were cache hits

1 test (100.0%) was fully cached saving 20ms.

Bazel-6

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 230ms.

Bazel-7

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 341ms.

Bazel-8

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 334ms.

Bazel-7

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 71ms.

Bazel-8

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 84ms.

Bazel-6

e2e/test

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.

Bazel-7

e2e/test

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.

Bazel-8

e2e/test

All tests were cache hits

176 tests (100.0%) were fully cached saving 8s.

Bazel-6

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 267ms.

Bazel-7

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 325ms.

Bazel-8

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 401ms.

Buildifier      Format

@alexeagle alexeagle merged commit 04286dd into main Nov 5, 2025
19 checks passed
@alexeagle alexeagle deleted the alexeagle-patch-2 branch November 5, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbedard jbedard jbedard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexeagle @jbedard